Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored ProxyConnector #998

Merged
merged 2 commits into from
Jul 24, 2016
Merged

Refactored ProxyConnector #998

merged 2 commits into from
Jul 24, 2016

Conversation

mind1m
Copy link
Contributor

@mind1m mind1m commented Jul 24, 2016

What do these changes do?

  1. Proxy request logic is moved from ProxyConnector to TCPConnector
  2. Proxy now is set in ClientSession.request() and can be changed for each subsequent request, e.g session.get("http://httpbin.org/get", proxy="http://localhost:8020")
  3. ProxyConnector stays for backwards compatibility, however now it is just a thin wrapper around TCPConnector.

Are there changes in behavior for the user?

Old ProxyConnector code still works, however new way is preferred.
Documentation is updated to reflect that change.

Related issue number

#985

Checklist

  • [+] I think the code is well written
  • [+] Unit tests for the changes exist
  • [+] Documentation reflects the changes

@mind1m mind1m changed the title Refactor ProxyConnector #985 Refactored ProxyConnector Jul 24, 2016
@coveralls
Copy link

coveralls commented Jul 24, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 97.975% when pulling 944524e on mind1master:master into 7eac9e3 on KeepSafe:master.

@asvetlov asvetlov merged commit cf6cb31 into aio-libs:master Jul 24, 2016
@asvetlov
Copy link
Member

Awesome!

This was referenced Jul 24, 2016
Closed
Closed
@asvetlov asvetlov mentioned this pull request Aug 26, 2016
Closed
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mind1m @coveralls @asvetlov